Closed emso-c closed 1 month ago
@anakin87 now that we addressed that the default value is "5m"
in the docs, you think we should update the default value to "5m"
in the code as well? It might be confusing for users to see that the value is None
, contradicting the docs.
Related Issues
Proposed Changes:
Added keep_alive parameter to
OllamaGenerator
andOllamaChatGenerator
How did you test it?
Ran unit tests:
Manual tests: Set keep alive to 0 and checked process consumptions.
Expected behavior:
The processes immediately getting unloaded from memory.
Actual behaviour:
The processes immediately getting unloaded from memory.
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.