deepset-ai / haystack-core-integrations

Additional packages (components, document stores and the likes) to extend the capabilities of Haystack version 2.0 and onwards
https://haystack.deepset.ai
Apache License 2.0
121 stars 119 forks source link

fix: make "project-id" parameter optional during initialization #1141

Closed Amnah199 closed 1 month ago

Amnah199 commented 1 month ago

Related Issues

Proposed Changes:

The project is automatically set during authentication using Google Cloud ADCs, which is required for configuration. Therefore, we can make the project-id optional in the component init.

How did you test it?

Notes for the reviewer

Checklist

Amnah199 commented 1 month ago

VertexAIGeminiChatGenerator is already updated. I'll update the tests too 👍

Amnah199 commented 1 month ago

@julian-risch updated the examples and also removed project_id from all tests except init. Let me know WDYT.