feat: add support for ttft - Githubissues

deepset-ai / haystack-core-integrations

Additional packages (components, document stores and the likes) to extend the capabilities of Haystack version 2.0 and onwards

https://haystack.deepset.ai

Apache License 2.0

121 stars 119 forks source link

feat: add support for ttft #1161

Closed LastRemote closed 1 week ago

LastRemote commented 3 weeks ago

Related Issues

see https://github.com/deepset-ai/haystack/pull/8444

Proposed Changes:

Support TTFT by casting isoformat to a datetime object and include it in a generation.

How did you test it?

Unit test. I also have E2E tests in my version, which is almost the same but not exactly.

Notes for the reviewer

Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

CLAassistant commented 3 weeks ago

All committers have signed the CLA.

vblagoje commented 3 weeks ago

Hey @LastRemote it seems like you nee to sign CLA for https://github.com/deepset-ai/haystack-core-integrations - perhaps you have already? 🙏

LastRemote commented 3 weeks ago

Hey @LastRemote it seems like you nee to sign CLA for https://github.com/deepset-ai/haystack-core-integrations - perhaps you have already? 🙏

No I actually haven't. But now it's done.