search

deepset-ai / haystack-core-integrations

Additional packages (components, document stores and the likes) to extend the capabilities of Haystack version 2.0 and onwards
https://haystack.deepset.ai
Apache License 2.0
121 stars 119 forks source link

feat: Snowflake connection params & permissions check update #1182

Closed iireland-ii closed 1 week ago

iireland-ii commented 1 week ago

Related Issues

Proposed Changes:

Added PrivateKey and PrivateKeyPwd parameters to allow more secure connection methodologies. Added an additional role parameter and altered the check permissions logic to ensure the role/user has SELECT access, rather than read-only select access.

How did you test it?

Tested locally with dev branch using live Snowflake instance.

Notes for the reviewer

I've added the parameters which are commonly used (at least within our org), there is scope to add further params or custom connections. Happy to make future feature branches for this or discuss these changes further.

CLAassistant commented 1 week ago

CLA assistant check
All committers have signed the CLA.