chore: Update OpenAPITool tests

deepset-ai / haystack-experimental

🧪 Experimental features for Haystack

https://haystack.deepset.ai

Apache License 2.0

23 stars 9 forks source link

chore: Update OpenAPITool tests #105

Closed vblagoje closed 1 month ago

vblagoje commented 1 month ago

adds skipif marker to test_allowed_operations unit test (fork repo sensitive test)
mark test_run_live_meteo_forecast_with_non_normalized_operation_id as unstable as meteo service can be often down

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11055672814

Details

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 90.082%

Files with Coverage Reduction	New Missed Lines	%
components/tools/openapi/_schema_conversion.py	3	88.79%
<!--	Total:	3		-->

Totals
Change from base Build 11049067911:	-0.2%
Covered Lines:	1426
Relevant Lines:	1583

💛 - Coveralls

vblagoje commented 1 month ago

@shadeMe @anakin87 This PR is intentionally coming from forked repo to test newly surfaced test failures described above

anakin87 commented 1 month ago

Just an observation: while working on #102, I noticed that unstable tests are never executed and kept this behavior.

vblagoje commented 1 month ago

Just an observation: while working on #102, I noticed that unstable tests are never executed and kept this behavior.

Yes, the idea (Madeesh and I talked about it) was - don't execute unstable tests on CI, but execute them locally. I'll revisit these tests as soon as I'm done with this Hackathon prep.