fix: OpenAI Chat Generator - do not create `TextContent` if `content` is `None`; make Anthropic Chat Generator more robust

anakin87 commented 2 weeks ago

Related Issues

While experimenting in an application with several Chat Generators, I encountered some errors passing ChatMessages generated by OpenAI to Anthropic.

Our implementation of OpenAI always creates a TextContent. Anthropic fails with empty text blocks. I think we should not create a "" TextContent if content is None. We should simply avoid creating it

Proposed Changes:

Do not create TextContent if content is None.

How did you test it?

CI, enriched existing tests

Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
I documented my code
I ran pre-commit hooks and fixed any issue

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 11663103763

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.461%

Totals
Change from base Build 11594818625:	0.0%
Covered Lines:	1859
Relevant Lines:	2078

💛 - Coveralls

vblagoje commented 2 weeks ago

@anakin87 reno note so we remember and communicate this decision?

anakin87 commented 2 weeks ago

We don't have Reno in this repository.

vblagoje commented 2 weeks ago

We don't have Reno in this repository.

Sorry, too many context switches for me 🤦

anakin87 commented 2 weeks ago

I put this on draft...

After more experimentation, I think we should also make Anthropic more robust.

UPDATE: done

deepset-ai / haystack-experimental