deepset-ai / haystack-tutorials

Here you can find all the Tutorials for Haystack 📓
https://haystack.deepset.ai/tutorials
Apache License 2.0
257 stars 87 forks source link

Run tutorials on latest Haystack version + on main #224

Closed bilgeyucel closed 1 year ago

bilgeyucel commented 1 year ago

Fixes #197

Updates

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

silvanocerza commented 1 year ago

I ran this version of the workflow and all the tutorials that were expected to run did. Some failed but that's expected, we'll fix them in a later PR. Workflow run: https://github.com/deepset-ai/haystack-tutorials/actions/runs/5643922044

It took a lot of time since we're running only 2 jobs at a time to avoid draining runners for the whole org. I don't think it's an issue since these are nightly and there's no haste for those.

All in all the workflow logic is sound and works as expected. We'll expand on that to handle tutorial extra dependencies in a separate PR.