Closed bilgeyucel closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
I ran this version of the workflow and all the tutorials that were expected to run did. Some failed but that's expected, we'll fix them in a later PR. Workflow run: https://github.com/deepset-ai/haystack-tutorials/actions/runs/5643922044
It took a lot of time since we're running only 2 jobs at a time to avoid draining runners for the whole org. I don't think it's an issue since these are nightly and there's no haste for those.
All in all the workflow logic is sound and works as expected. We'll expand on that to handle tutorial extra dependencies in a separate PR.
Fixes #197
Updates
generate_matrix.py
to generate the tutorial matrixhaystack_version
info to pick the correct docker image to run the testnightly.yml
to get the matrix from thegenerate_matrix.py
scriptneeds_gpu
and skip the nightly tests for these tutorials