deepset-ai / haystack-tutorials

Here you can find all the Tutorials for Haystack 📓
https://haystack.deepset.ai/tutorials
Apache License 2.0
227 stars 80 forks source link

Add conditional router tutorial #287

Closed bilgeyucel closed 4 months ago

bilgeyucel commented 4 months ago

Fixes #279

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

bilgeyucel commented 4 months ago

After rechecking the pipeline, I don't think using a Multiplexer adds any value here. Current run():

pipe.run({"prompt_builder": {"query": query, "documents": documents}, "router": {"query": query}})

run() with a Multiplexer:

pipe.run({"prompt_builder": {"documents": documents}, "multiplexer": {"query": query}})

Now that we've decided not to switch to ChatGenerators, there is nothing to change here. @TuanaCelik please take one last look when you can 🙌