Closed sjrl closed 2 months ago
Totals | |
---|---|
Change from base Build 10419214121: | 0.06% |
Covered Lines: | 6959 |
Relevant Lines: | 7716 |
@sjrl I have pushed a small change to fix typing issues. Please take a look and confirm it is ok. Let's wait for the docstrings review...
@sjrl I have pushed a small change to fix typing issues. Please take a look and confirm it is ok. Let's wait for the docstrings review...
Thanks! Looks good, I only made one small change to the docstring
Related Issues
Proposed Changes:
This adds the parameter
min_top_k
to the TopPSampler which sets the minimum number of documents to be returned when the top-p sampling algorithm results in fewer documents being selected. The documents with the next highest scores are added to the selection.This is useful when we want to guarantee a set number of documents will always be passed on, but allow the Top-P algorithm to still determine if more documents should be sent based on document score.
Also some minor refactoring was done. The biggest change/addition was changing
ComponentError
s tologger.warning
messages to allow the component to still run even when running into small edge cases.How did you test it?
Expanded tests
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.