Closed alperkaya closed 1 month ago
@davidsbatista
no need to add the warning to the tests just in the initialisation of the following components:
@alperkaya please sign the Contributor License Agreement otherwise this can't be merged.
Just a few notes:
And thank you once again for the initiative, appreciated!
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
components/generators/openai.py | 3 | 96.51% | ||
components/generators/chat/openai.py | 13 | 79.65% | ||
<!-- | Total: | 16 | --> |
Totals | |
---|---|
Change from base Build 10598482118: | 0.005% |
Covered Lines: | 7002 |
Relevant Lines: | 7763 |
@alperkaya please sign the Contributor License Agreement otherwise this can't be merged.
Just a few notes:
* Be sure to fill in the PR comments giving a bit more details as the template suggests. * Give a more complete title to the PR and be sure to add the prefix. * When in doubt ask/comment in the PR comments.
And thank you once again for the initiative, appreciated!
Hi @davidsbatista,
Thank you for clear instructions and descriptions. I just sign the license. I hope it is ready for merge now.
Related Issues
Proposed Changes:
How did you test it?
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.