Closed aicam closed 1 month ago
@aicam thanks for this contribution. I agree with you this is something that many users might need but due to its simplicity I'm not sure we should include it as the main component as most users can implement, and further customize, such a component themselves.
cc @julian-risch @shadeMe
@aicam thanks for this contribution. I agree with you this is something that many users might need but due to its simplicity I'm not sure we should include it as the main component as most users can implement, and further customize, such a component themselves.
cc @julian-risch @shadeMe
Thank you for your feedback. I understand the concern regarding the simplicity of the component. I'd be happy to work on making the component more customizable, allowing users to tailor it to their specific needs. Would this make it more suitable for inclusion as a main component? I’m open to suggestions on how to enhance its flexibility and usefulness for the broader user base.
@aicam thanks for your effort and eagerness to contribute – it’s always great to see enthusiasm from our community! However, after internal discussion, we believe it might not be the best fit as a main component due to its simplicity which most users can implement and customize themselves.
Having said that we’d welcome your skills applied in other tasks. If you’re interested feel free to take a look at our Contributions wanted list where you might find other issue that pique your interest. If in doubt reach out to me or another core developer cc @julian-risch . Looking forward to your future contributions!
Proposed Changes:
FilterByNumWords
is used to filter output of retrievers in a pipeline to make sure it does not exceeds LLM input size. This component is added inpreprocessors
module and can be used in pipelines. It counts number of words simply by counting.split(' ')
.Usage:
How did you test it?
Unit testing added.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.