Closed sjrl closed 1 month ago
Totals | |
---|---|
Change from base Build 11035435372: | 0.0% |
Covered Lines: | 7414 |
Relevant Lines: | 8212 |
Integrated this in #8431 with 149f92fc2c64e9521efd21b3b15a58b539772911 and some small fixes with c730077a444e95f62f54709e8bc017cadb8783ca.
Related Issues
Adds a new behavorial test based on this issue https://github.com/deepset-ai/haystack/issues/8389
@silvanocerza this is also fixed by the subgraphs branch.
Note: This test will still fail currently with the subgraphs branch b/c Doc comparison is fragile when Documents have scores. By this I mean a Doc is assigned a float score by the Retriever and the Doc
__eq__
method only does an exact comparison. This breaks when comparing floats due to the imprecision with long decimals.Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.