deepset-ai / haystack

AI orchestration framework to build customizable, production-ready LLM applications. Connect components (models, vector DBs, file converters) to pipelines or agents that can interact with your data. With advanced retrieval methods, it's best suited for building RAG, question answering, semantic search or conversational agent chatbots.
https://haystack.deepset.ai
Apache License 2.0
17.72k stars 1.92k forks source link

test: Add new behavioral test #8411

Closed sjrl closed 1 month ago

sjrl commented 1 month ago

Related Issues

Adds a new behavorial test based on this issue https://github.com/deepset-ai/haystack/issues/8389

@silvanocerza this is also fixed by the subgraphs branch.

Note: This test will still fail currently with the subgraphs branch b/c Doc comparison is fragile when Documents have scores. By this I mean a Doc is assigned a float score by the Retriever and the Doc __eq__ method only does an exact comparison. This breaks when comparing floats due to the imprecision with long decimals.

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11051101178

Details


Totals Coverage Status
Change from base Build 11035435372: 0.0%
Covered Lines: 7414
Relevant Lines: 8212

💛 - Coveralls
silvanocerza commented 1 month ago

Integrated this in #8431 with 149f92fc2c64e9521efd21b3b15a58b539772911 and some small fixes with c730077a444e95f62f54709e8bc017cadb8783ca.