unit tests

[samueldmcdermott]

related to #35

[cavestruz]

• [x] Unit test stubs for each module
• [x] Fill out unit tests for module <>

[samueldmcdermott]

I think the tests I wrote in branch newtests have decent coverage but this is my first time writing them, so I'm happy for feedback! @cavestruz @humnaawan @bnord

[samueldmcdermott]

I'm happy to merge, or would it better to submit a pull request and have someone review?

[cavestruz]

Always good practice to submit a PR, even if you're self-reviewing before the merge.

On Fri, May 26, 2023, 10:30 samueldmcdermott @.***> wrote:

I'm happy to merge, or would it better to submit a pull request and have someone review?

— Reply to this email directly, view it on GitHub https://github.com/deepskies/simcmb/issues/55#issuecomment-1564483617, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEVG6YIFQF5K6BRA2K45CDXIC5APANCNFSM6AAAAAAXNAHQBI . You are receiving this because you were mentioned.Message ID: @.***>

[samueldmcdermott]

oh, indeed, that’s how I’ve been doing it. Just didn’t know who to assign it to (myself or one of you)

[samueldmcdermott]

(also, wasn’t totally sure if it was ready to merge)

[bnord]

do you want me to be a reviewer on this?