deepskies / deeplenstronomy

A pipeline for versatile strong lens sample simulations
MIT License
26 stars 7 forks source link

ccd gain and magnitude zero point are not added into the image #131

Closed jsv1206 closed 1 year ago

AeRabelais commented 1 year ago

Inputs into the yaml files but aren't being used anywhere in the code. We're double checking this statement!

Jasonpoh commented 1 year ago

I think it's being encoded in Image and Survey parameters and passed into lenstronomy.

` # IMAGE elif param in ['exposure_time', 'numPix', 'pixel_scale', 'psf_type', 'read_noise', 'ccd_gain']: return "['IMAGE']['PARAMETERS']['{0}']".format(param)

# SURVEY
elif param in ['BANDS', 'seeing', 'magnitude_zero_point', 'sky_brightness', 'num_exposures']:
    return "['SURVEY']['PARAMETERS']['{0}']".format(param)`
AeRabelais commented 1 year ago

In review!

Jasonpoh commented 1 year ago

These kwargs get passed into lenstronomy's simAPI object and added to the image.

For the CCD gain, the default data_count_unit is in electron count and ignores CCD gain. But if you specify data_count_unit: 'ADU', it will take into account the CCD gain.