search

deepskies / deeplenstronomy

A pipeline for versatile strong lens sample simulations
MIT License
26 stars 7 forks source link

Draw 0m #137

Closed jsv1206 closed 11 months ago

jsv1206 commented 11 months ago

Added a functionality to draw Om0 from a distribution and set Om0 + Ode0 = 1.

Also included if conditions to make sure even if parameters not included in a certain cosmology are given in the yaml file, the appropriate parameters set in the code are only considered.

e.g. even if Ode0 is given for 'FlatLamdaCDM' in the yaml file, it wouldn't;t give an error as the parameters for this cosmology are set to cosmology_info = ['H0', 'Om0', 'Tcmb0', 'Neff', 'm_nu', 'Ob0']

review-notebook-app[bot] commented 11 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

voetberg commented 11 months ago

Do you have tests that check both the if and the else? Useful to include.