Converted BatchStacking dialog to Qt

[aiustin]

I just converted it to Qt and kept the existing behaviour. I think there's room for improvement but it's probably not a priority. Two questions though:

• saving & restoring position: except for the main window it doesn't look like other dialogs are still doing that (or I missed the code). Do you still want to keep it here?
• I ran the non-Qt version and the filter for files there also includes '.dssfilelist' while in the existing code I could only see '.txt'. Is that intended or am I missing something?

[perdrix52]

I will look at this tomorrow.

Thank you, David

From: Iustin Amihaesei @.> Sent: 04 December 2022 17:20 To: deepskystacker/DSS @.> Cc: Subscribed @.***> Subject: [deepskystacker/DSS] Converted BatchStacking dialog to Qt (PR #155)

I just converted it to Qt and kept the existing behaviour. I think there's room for improvement but it's probably not a priority. Two questions though:

• saving & restoring position: except for the main window it doesn't look like other dialogs are still doing that (or I missed the code). Do you still want to keep it here?

• I ran the non-Qt version and the filter for files there also includes '.dssfilelist' while in the existing code I could only see '.txt'. Is that intended or am I missing something?

  ---

You can view, comment on, or merge this pull request online at:

https://github.com/deepskystacker/DSS/pull/155

Commit Summary

• 59ee955 https://github.com/deepskystacker/DSS/pull/155/commits/59ee95574e190cbf9e7740e3a83c1373d6f7ffef Converted BatchStacking dialog to Qt

File Changes

(5 https://github.com/deepskystacker/DSS/pull/155/files files)

• M DeepSkyStacker/BatchStacking.cpp https://github.com/deepskystacker/DSS/pull/155/files#diff-bc87bb217fbe9052ddcec64948df9772e376298502c7a5f0371f4264256f3626 (469)
• M DeepSkyStacker/BatchStacking.h https://github.com/deepskystacker/DSS/pull/155/files#diff-1a5995723b15e314fa8fb503c68e1a9ed41a2bab0c7ba0b1cd15327ffbc8aa2b (85)
• M DeepSkyStacker/DeepSkyStacker.vcxproj https://github.com/deepskystacker/DSS/pull/155/files#diff-932f56e4facaed7cf0a9d5afc64dd09e099f87333c4d955bddb758715995706a (2)
• M DeepSkyStacker/StackingDlg.cpp https://github.com/deepskystacker/DSS/pull/155/files#diff-5b10378638d1e000fa317c1519a5475b80732160f2221232e76be104e721884d (7)
• M DeepSkyStacker/ui/BatchStacking.ui https://github.com/deepskystacker/DSS/pull/155/files#diff-7e259ba8afd250d4b2e7553c9ee13953c31f3158fcd427679c559f101e3568fa (14)

Patch Links:

• https://github.com/deepskystacker/DSS/pull/155.patch
• https://github.com/deepskystacker/DSS/pull/155.diff

— Reply to this email directly, view it on GitHub https://github.com/deepskystacker/DSS/pull/155 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2GQMVXASXVSGDNWJACCKTWLTHC3ANCNFSM6AAAAAASTO6GB4 . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AE2GQMXVBBWTLW6EXEHQ7GDWLTHC3A5CNFSM6AAAAAASTO6GB6WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFP2W2Y4.gif Message ID: @. @.> >

[perdrix52]

As an example of save/restore geometry for dialogs, look at e.g. StackRecap.cpp mfs onInitDialog(), accept() and reject()

From: Iustin Amihaesei @.> Sent: 04 December 2022 17:20 To: deepskystacker/DSS @.> Cc: Subscribed @.***> Subject: [deepskystacker/DSS] Converted BatchStacking dialog to Qt (PR #155)

I just converted it to Qt and kept the existing behaviour. I think there's room for improvement but it's probably not a priority. Two questions though:

• saving & restoring position: except for the main window it doesn't look like other dialogs are still doing that (or I missed the code). Do you still want to keep it here?

• I ran the non-Qt version and the filter for files there also includes '.dssfilelist' while in the existing code I could only see '.txt'. Is that intended or am I missing something?

  ---

You can view, comment on, or merge this pull request online at:

https://github.com/deepskystacker/DSS/pull/155

Commit Summary

• 59ee955 https://github.com/deepskystacker/DSS/pull/155/commits/59ee95574e190cbf9e7740e3a83c1373d6f7ffef Converted BatchStacking dialog to Qt

File Changes

(5 https://github.com/deepskystacker/DSS/pull/155/files files)

• M DeepSkyStacker/BatchStacking.cpp https://github.com/deepskystacker/DSS/pull/155/files#diff-bc87bb217fbe9052ddcec64948df9772e376298502c7a5f0371f4264256f3626 (469)
• M DeepSkyStacker/BatchStacking.h https://github.com/deepskystacker/DSS/pull/155/files#diff-1a5995723b15e314fa8fb503c68e1a9ed41a2bab0c7ba0b1cd15327ffbc8aa2b (85)
• M DeepSkyStacker/DeepSkyStacker.vcxproj https://github.com/deepskystacker/DSS/pull/155/files#diff-932f56e4facaed7cf0a9d5afc64dd09e099f87333c4d955bddb758715995706a (2)
• M DeepSkyStacker/StackingDlg.cpp https://github.com/deepskystacker/DSS/pull/155/files#diff-5b10378638d1e000fa317c1519a5475b80732160f2221232e76be104e721884d (7)
• M DeepSkyStacker/ui/BatchStacking.ui https://github.com/deepskystacker/DSS/pull/155/files#diff-7e259ba8afd250d4b2e7553c9ee13953c31f3158fcd427679c559f101e3568fa (14)

Patch Links:

• https://github.com/deepskystacker/DSS/pull/155.patch
• https://github.com/deepskystacker/DSS/pull/155.diff

— Reply to this email directly, view it on GitHub https://github.com/deepskystacker/DSS/pull/155 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2GQMVXASXVSGDNWJACCKTWLTHC3ANCNFSM6AAAAAASTO6GB4 . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AE2GQMXVBBWTLW6EXEHQ7GDWLTHC3A5CNFSM6AAAAAASTO6GB6WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFP2W2Y4.gif Message ID: @. @.> >

[aiustin]

Yes. Saw that. What I meant is I didn't see a generic impl for dialogs like SaveWindowPosition, so I was not sure if you want to keep it. I'll save the geometry then.