deepskystacker / DSS

DeepSkyStacker
Other
894 stars 90 forks source link

Incorrect temp directory, 5.1.5, Windows 11 #204

Closed cykelstativet closed 7 months ago

cykelstativet commented 7 months ago

Version 5.1.5, Windows 11 21H2 22000

Describe the bug Temporary files are created NEXT to the selected directory, instead of INSIDE the directory. If the selected directory is "C:\temp\" then the files will be found at "C:\dssfile.tmp\" instead of "C:\temp\dssfile.tmp\".

Provide necessary data to reproduce the problem Install DSS and stack images. I have tried reinstalling the application, as well as clearing all settings and files related to DSS.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Stack Checked Pictures'.
  2. Click on 'Stacking Settings'.
  3. Click on 'Temporary files folder'.
  4. Select the directory where temporary files should be created.

Expected behavior Temporary files are created inside the selected directory.

Additional context I suspect that DSS simply lacks a '/' at the end of the path. The temp files appear to have the directory appended in the beginning of the files. So if the selected directory is called "temp" the files will be called "tempDSSxxxxx.tmp". If the directory is "dssfiles" the files will be called "dssfilesDSSxxxxx.tmp".

perdrix52 commented 7 months ago

Thank you for that diagnosis. I think you’re absolutely correct.

I’m in the throes of a house move (move date 2st Feb.) so won’t have time to write a fix myself.

Perhaps one of the other devs (Simon?) could look at the code in question and fix it?

From: cykelstativet @.> Sent: 27 January 2024 09:36 To: deepskystacker/DSS @.> Cc: Subscribed @.***> Subject: [deepskystacker/DSS] Incorrect temp directory, 5.1.5, Windows 11 (Issue #204)

Version 5.1.5, Windows 11 21H2 22000

Describe the bug Temporary files are created NEXT to the selected directory, instead of INSIDE the directory. If the selected directory is "C:\temp" then the files will be found at "C:\dssfile.tmp" instead of "C:\temp\dssfile.tmp".

Provide necessary data to reproduce the problem Install DSS and stack images. I have tried reinstalling the application, as well as clearing all settings and files related to DSS.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Stack Checked Pictures'.
  2. Click on 'Stacking Settings'.
  3. Click on 'Temporary files folder'.
  4. Select the directory where temporary files should be created.

Expected behavior Temporary files are created inside the selected directory.

Additional context I suspect that DSS simply lacks a '/' at the end of the path. The temp files appear to have the directory appended in the beginning of the files. So if the selected directory is called "temp" the files will be called "tempDSSxxxxx.tmp". If the directory is "dssfiles" the files will be called "dssfilesDSSxxxxx.tmp".

— Reply to this email directly, view it on GitHub https://github.com/deepskystacker/DSS/issues/204 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2GQMQOHY54MRMO5Q2QSXLYQTC7BAVCNFSM6AAAAABCNHK3K2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYDGNBXGQZDMMI . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AE2GQMXFND5Y7LVYYEHKO5DYQTC7BA5CNFSM6AAAAABCNHK3K2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHH2YDYKU.gif Message ID: @. @.> >

perdrix52 commented 7 months ago

I managed to find some time to look at this. Are you up for testing a fix?

David

cykelstativet commented 7 months ago

Sorry for the delay, I didn't get my email notification..

I managed to find some time to look at this. Are you up for testing a fix?

Absolutely :)

perdrix52 commented 7 months ago

Please try this: https://www.dropbox.com/scl/fi/al8w13hqig6dpi5mleezp/DSS-5.1.5-Test-Build-Setup.exe?rlkey=nvcp3vksc7eezwucm5f1k276e&dl=1

David

cykelstativet commented 7 months ago

After next to no testing - just did one stack of the 45 minutes I happened to capture this night - it does indeed seem to work. All stacks on the official release had the same issue, so even a single stack that doesn't do it is proof enough for me :)

perdrix52 commented 7 months ago

Many thanks, that will be fixed in the next release

From: cykelstativet @.> Sent: 08 February 2024 20:06 To: deepskystacker/DSS @.> Cc: David C. Partridge @.>; Comment @.> Subject: Re: [deepskystacker/DSS] Incorrect temp directory, 5.1.5, Windows 11 (Issue #204)

After next to no testing - just did one stack of the 45 minutes I happened to capture this night - it does indeed seem to work. All stacks on the official release had the same issue, so even a single stack that doesn't do it is proof enough for me :)

— Reply to this email directly, view it on GitHub https://github.com/deepskystacker/DSS/issues/204#issuecomment-1934853626 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2GQMVTHIUPVMC35BZNWUDYSUV25AVCNFSM6AAAAABCNHK3K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUHA2TGNRSGY . You are receiving this because you commented. https://github.com/notifications/beacon/AE2GQMW4LLEVDZ3RU35HJHDYSUV25A5CNFSM6AAAAABCNHK3K2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTTKOC7U.gif Message ID: @. @.> >