search

deepsphere / deepsphere-cosmo-tf2

A spherical convolutional neural network for cosmology (TFv2).
https://arxiv.org/abs/1810.12186
MIT License
19 stars 5 forks source link

Add layers using Bernstein approximation #5

Closed mty1203 closed 2 years ago

mty1203 commented 2 years ago

see https://arxiv.org/abs/2106.10994

jafluri commented 2 years ago

Hello,

Thanks a lot for your interest and contribution to Deepsphere for TF 2.x. Could you please address the following issues?

Could you please make the new layer a subclass of tensorflow.keras.Model instead of tensorflow.keras.Layer in gnn_layers.py

https://github.com/deepsphere/deepsphere-cosmo-tf2/blob/2f4eb4228e7e354ab9ac821d8c9db1c27424da86/deepsphere/gnn_layers.py#L374

There is a missing reference to the function comb in gnn_layers.py:

https://github.com/deepsphere/deepsphere-cosmo-tf2/blob/2f4eb4228e7e354ab9ac821d8c9db1c27424da86/deepsphere/gnn_layers.py#L489

There is an indentation error in healpy_layers.py:

https://github.com/deepsphere/deepsphere-cosmo-tf2/blob/2f4eb4228e7e354ab9ac821d8c9db1c27424da86/deepsphere/healpy_layers.py#L370

Thanks a lot!