search

deepsphere / deepsphere-pytorch

DeepSphere: a graph-based spherical CNN (PyTorch)
https://arxiv.org/abs/2012.15000
MIT License
154 stars 29 forks source link

typo at line 106 #3

Closed aurelio-amerio closed 4 years ago

aurelio-amerio commented 4 years ago

Changed Nside -> nside, to match the function signature at pygsp. Furthermore, I've set n_neighbours=None, since the default option (50) would raise an error.

aurelio-amerio commented 4 years ago

There was a mistake in the formula to compute pixel_num. At each step nside (which is called resolution here) should be divided by 2. Using the previous formula would result in errors for depth>=3

mdeff commented 4 years ago

Thanks!

The default n_neighbours should be updated in the PyGSP. I should review and merge this branch...