deepstreamIO / deepstream.io-client-java

The Java/Android Client for deepstream.io
Other
35 stars 37 forks source link

Moved all Swift Extensions to 1 file. Create client in Global thread #70

Closed akramhussein closed 7 years ago

akramhussein commented 7 years ago

To create iOS client, do the following:

IOSDeepstreamFactory.getInstance().getClient("<PASTE-YOUR-DSH-URL>", callback: { (client) in guard let c = client else { print("Unable to initialize client") return } })

yasserf commented 7 years ago

@jdmnd shouldn't this be merged?

akramhussein commented 7 years ago

Some of the extensions could be made private now so they aren't exposed to the user.

On Tue, 21 Mar 2017 at 08:11, Yasser Fadl notifications@github.com wrote:

@jdmnd https://github.com/jdmnd shouldn't this be merged?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/deepstreamIO/deepstream.io-client-java/pull/70#issuecomment-288004892, or mute the thread https://github.com/notifications/unsubscribe-auth/AAj0um83p5i4mfVN1uY5VWPw3TL3N3x4ks5rn4ZKgaJpZM4MieLJ .

-- Kind regards,

Akram

jdmnd commented 7 years ago

@yasserf I rebased onto master, will close this issue.

@akramhussein Can IOSEndpointWebsocket and IOSEndpointWebsocketFactory be made private? Any others?

Will close this pr in a sec.

akramhussein commented 7 years ago

@jdmnd yup - just checked and those two only.