deepstreamIO / deepstream.io

deepstream.io server
https://deepstreamio.github.io
MIT License
7.14k stars 381 forks source link

TypeScript Compile Error : An accessor cannot be declared in an ambient context #1074

Closed gigenthomas closed 4 years ago

gigenthomas commented 4 years ago

typescript : 3.5.3 Angular CLI: 8.3.28 Node: 12.18.0 @deepstream/client": 5.0.8

"typeRoots": [ "node_modules/@deepstream/client/deepstream-client.d.ts" ]

Get the following error after upgrade to Angular 8. Works just fine in Angular 7.

ERROR in node_modules/@deepstream/client/dist/connection/connection.d.ts:27:9 - error TS1086: An accessor cannot be declared in an ambient context.

27 get isConnected(): boolean;

Any help is greatly appreciated !!

Gigen

jaime-ez commented 4 years ago

Hi, can you re-open the issue in the deepstream client repo since it is a client issue? Thanks

yasserf commented 4 years ago

seems this is an issue with angular/typescript version

https://github.com/storybookjs/storybook/issues/9463

easiest thing is apparently adding "skipLibCheck": true

gigenthomas commented 4 years ago

Thank you @yasserf . Confirmed that the above fix works

Regards, Gigen Thomas