search

deepstreamIO / deepstream.io

deepstream.io server
https://deepstreamio.github.io
MIT License
7.14k stars 382 forks source link

uws above version v18 causes uws http server to crash #1079

Closed fortranlee closed 4 years ago

fortranlee commented 4 years ago

The parameter request is no longer available since this commit

https://github.com/uNetworking/uWebSockets.js/commit/b4df9ebf5f4c3ecc884d5f5e0df1cd04b8caa7c3#diff-01c1a4e28835a7d097ce62009d6e3db1L97-R127

jaime-ez commented 4 years ago

Indeed, perhaps the upgrade property should be used now: https://unetworking.github.io/uWebSockets.js/generated/interfaces/websocketbehavior.html#upgrade and then pass the url to the ws connection as in this example: https://github.com/uNetworking/uWebSockets.js/blob/master/examples/Upgrade.js

Feel free to make a pull request, I'll try to work on it this weekend.

yasserf commented 4 years ago

👍 nice!