search

deepstreamIO / deepstream.io

deepstream.io server
https://deepstreamio.github.io
MIT License
7.14k stars 381 forks source link

enable file auth path and multiple authentication stategies #1085

Closed jaime-ez closed 3 years ago

jaime-ez commented 3 years ago

1041

Enable CombineAuthentication, a very useful feature that was unused and undocumented (to be done).

jaime-ez commented 3 years ago

Regarding the multiple auth strategies. Taking a second look to the code base, when a login is unsuccesfull, some services return null or {isValid: false}. If the service returns null, the combine will continue iterating, otherwise it will return. For file and for storage auth strategies there is reportInvalidParameters option that will force {isValid:false}. It is http webhook the one that is breaking this logic. A reportInvalidParameters option should be added to fail or continue for the http webhook and thus keep the combine auth as it was.

Comments?

yasserf commented 3 years ago

This looks good to me! Thanks!

jaime-ez commented 3 years ago

Ok I'll update the pull soon to reflect the previous proposal