Closed hugojosefson closed 10 months ago
Awesome, I'll check the change and leave some comments
Thank you @jaime-ez for taking the time to review and merge this!
Thanks @daanh432 and @hugojosefson for your PRs! Awesome to see some actual work on the project from others. new release will be available soon, please test and inform any issues.
Cheers
This builds upon https://github.com/deepstreamIO/deepstream.io/pull/1134 by @daanh432, which uses Node.js 18. In this PR, I upgrade (almost) all other dependencies, for security, and for trying to stay up-to-date.
For some dependencies, such as
typescript
v4 → v5, the amount of things to fix after such an upgrade was too great for me at the moment, so I stayed on the latest minor version I could successfully upgrade to.Some minor, and some major, version upgrades to dependencies required small updates in code, which I included in each such upgrade commit together with the dependency version bump.
I successfully ran this command, at least after every major version upgrade commit, and at the end:
That way, I feel confident this should work.
I have also tested the major upgrade of
commander
manually with the built executable./build/deepstream
, to make sure it sees thestart
command as the default and chooses the correct command when given another one.I updated one test to make it work correctly in both Node.js 18 and Node.js 20, because the error message it checks for, becomes longer and more specific in Node.js 20.
Build is green on my fork's GitHub Actions: https://github.com/hugojosefson/deepstream.io/actions/runs/6591970600