search

deepstreamIO / deepstream.io

deepstream.io server
https://deepstreamio.github.io
MIT License
7.14k stars 381 forks source link

3.1.4 for mac? #902

Closed brianbrownton closed 5 years ago

brianbrownton commented 6 years ago

image

Will there be a binary released?

yasserf commented 6 years ago

Hello!

I'm actually facing an issue with mac due to the latest osx-update and compiling node. Getting an error saying that a certain library doesn't exist.

Its next on my list.

brianbrownton commented 6 years ago

Thanks for the reply.

I am trying to maintain this for homebrew. We will obviously have to stay on 3.1.3 until a binary is for 3.1.4 or later is released :)

yasserf commented 6 years ago

Thank you! I'll try to get it done asap. If anyone has an older version of osx maybe they could run the build? It's pretty simple and takes around 20minutes to get the artifact 😅😁

On Tue, 3 Jul 2018, 17:53 Brian Morton, notifications@github.com wrote:

Thanks for the reply.

I am trying to maintain this for homebrew. We will obviously have to stay on 3.1.3 until a binary is for 3.1.4 or later is released :)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/deepstreamIO/deepstream.io/issues/902#issuecomment-402223613, or mute the thread https://github.com/notifications/unsubscribe-auth/ACm7S3JGC19In6uUvi2MsWooQHBxIZy7ks5uC6FwgaJpZM4VAGox .

brianbrownton commented 6 years ago

I'm on high sierra - I'll have a look at the build docs and see. If I end up with a binary, how would I get it to you?

brianbrownton commented 6 years ago

This likely isn't happening for me unless you have an easy way to switch back to node 6.14 - not willing to risk mucking up my current environment!

edit: i think i've got it running by hacking some shell functions to replace the node/npm calls to the older versions

brianbrownton commented 6 years ago 
$ ./scripts/package.sh v3.1.4
[...]
Creating 'build/deepstream', this will take a while...
Compiling deepstream... (1 SECONDS)....> WARNING: src/node.js doesn't exist. Trying 'lib/internal/bootstrap_node.js'
Compiling deepstream... (2 SECONDS)gyp: undefined not found (cwd: /private/tmp/dsio/nexe_node/node/6.14.3/node-v6.14.3) while trying to load undefined
Compiling deepstream... (12 SECONDS)In file included from ../src/async-wrap.cc:1:
In file included from ../src/async-wrap-inl.h:7:
In file included from ../src/base-object-inl.h:7:
In file included from ../src/env-inl.h:6:
In file included from ../src/env.h:7:
In file included from ../src/debug-agent.h:27:
In file included from ../src/node_mutex.h:4:
../src/util.h:21:10: fatal error: 'tr1/type_traits' file not found
#include <tr1/type_traits>  // NOLINT(build/c++tr1)
         ^~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [/private/tmp/dsio/nexe_node/node/6.14.3/node-v6.14.3/out/Release/obj.target/node_lib/src/async-wrap.o] Error 1
make: *** [node] Error 2
....> ERROR: The release executable has not been generated. This indicates a failure in the build process. There is likely additional information above.
yasserf commented 6 years ago

Ah same issue I have =(. Its generally an issuing compiling node over deepstream. Not sure when what library updated that broke it in osx =(.

Thanks for checking it out! And for node env, I use n https://github.com/tj/n, works perfectly for me when trying out different combos!

Small difference is just that you need to run ./scripts/package.sh true (the version is always the latest from master package.json). We probably just check the first arg is true but it doesn't actually commit to a specific version.

I'm hoping to get uws running with node 8, that might fix the issue (plus it worked before, but something regressed)

On Tue, Jul 3, 2018 at 11:15 PM Brian Morton notifications@github.com wrote:

$ ./scripts/package.sh v3.1.4 [...] Creating 'build/deepstream', this will take a while... Compiling deepstream... (1 SECONDS)....> WARNING: src/node.js doesn't exist. Trying 'lib/internal/bootstrap_node.js' Compiling deepstream... (2 SECONDS)gyp: undefined not found (cwd: /private/tmp/dsio/nexe_node/node/6.14.3/node-v6.14.3) while trying to load undefined Compiling deepstream... (12 SECONDS)In file included from ../src/async-wrap.cc:1: In file included from ../src/async-wrap-inl.h:7: In file included from ../src/base-object-inl.h:7: In file included from ../src/env-inl.h:6: In file included from ../src/env.h:7: In file included from ../src/debug-agent.h:27: In file included from ../src/node_mutex.h:4: ../src/util.h:21:10: fatal error: 'tr1/type_traits' file not found

include <tr1/type_traits> // NOLINT(build/c++tr1)

     ^~~~~~~~~~~~~~~~~

1 error generated. make[1]: [/private/tmp/dsio/nexe_node/node/6.14.3/node-v6.14.3/out/Release/obj.target/node_lib/src/async-wrap.o] Error 1 make: [node] Error 2 ....> ERROR: The release executable has not been generated. This indicates a failure in the build process. There is likely additional information above.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/deepstreamIO/deepstream.io/issues/902#issuecomment-402307658, or mute the thread https://github.com/notifications/unsubscribe-auth/ACm7S1Bd0DQemwaOURPMkgpzv_rtw5Ooks5uC-zxgaJpZM4VAGox .

yasserf commented 6 years ago

Got this working by rolling back. Will work in next update!

brianbrownton commented 6 years ago

Cool, thanks for the hard work and keeping this updated. Let me know when its released (here), and then I'll link the update PR and close the issue.

daveoon commented 6 years ago

I have deployed one on my mac by compiling a docker version, you can pull from my repo at docker pull daveoon/deepstream:3.1.4

hope this helps

brianbrownton commented 6 years ago

@daveoon unless there is an official public download url, I'm afraid that won't fall into the guidelines for homebrew

dmundy2 commented 6 years ago

Hey, any update on getting this into Brew?

brianbrownton commented 6 years ago

@dmundy2 until this ticket is updated with an official public download URL of the binary, it won't be added to brew.

yasserf commented 5 years ago

hello!

Sorry for not updating this, I have been swamped trying to get V4 done since theres an overhaul of alot of things back to OS land.

Good news is V4 is literally almost publishable, I just need to write an upgrade guide and a whole lot of documentation around new features. Any chance your still using deepstream and happy to update brew in a weeks time with the official release?

thanks!

brianbrownton commented 5 years ago

@yasserf if you're providing a binary, then yes. if i have to build it, then no :)

yasserf commented 5 years ago

Will provide an official artefact! Build is mostly up and running again. Thanks!

On Wed, 29 May 2019 at 15:04, Brian Morton notifications@github.com wrote:

@yasserf https://github.com/yasserf if you're providing a binary, then yes. if i have to build it, then no :)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/deepstreamIO/deepstream.io/issues/902?email_source=notifications&email_token=AAU3WS4O5RLJG5PCOWNWYBDPXZ5MHA5CNFSM4FIANIY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPIFCY#issuecomment-496927371, or mute the thread https://github.com/notifications/unsubscribe-auth/AAU3WS4OCHLLQ7ZRHOTUDODPXZ5MHANCNFSM4FIANIYQ .

yasserf commented 5 years ago

Will update this issue once an official V4 binary is out. Thanks again!