search

deepsweet / isparta-loader

💯 isparta instrumenter loader for webpack
117 stars 22 forks source link

Use babel options from webpack config like babel-loader do #3

Closed vslinko closed 8 years ago

atondelier commented 9 years ago

:+1: Passing babel options is definitely needed. But, directly reading into options.babel may be the fallback for reading into a options.isparta object.

vslinko commented 9 years ago

@atondelier are you sure that someone needs different babel config for isparta?

vslinko commented 9 years ago

@deepsweet what are you think?

atondelier commented 9 years ago

@vslinko I agree it will be the same most of the time. I suggested that only for flexibility, e.g. if you want a specific shouldPrintComment babel callback for isparta instrumenter.

vslinko commented 9 years ago

@atondelier Updated PR.