deeptime-ml / deeptime

Python library for analysis of time series data including dimensionality reduction, clustering, and Markov model estimation
https://deeptime-ml.github.io/
GNU Lesser General Public License v3.0
757 stars 84 forks source link

Update validation loss on TAE #205

Closed clarktemple03 closed 2 years ago

clarktemple03 commented 2 years ago

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

Update to TAE so that validation loss is reading from validation_dataloader

codecov[bot] commented 2 years ago

Codecov Report

Merging #205 (f273aef) into main (dd91e12) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   93.74%   93.72%   -0.02%     
==========================================
  Files         136      136              
  Lines       10765    10765              
==========================================
- Hits        10092    10090       -2     
- Misses        673      675       +2     
Impacted Files Coverage Δ
deeptime/decomposition/deep/_tae.py 99.05% <100.00%> (ø)
deeptime/markov/msm/tram/_tram_dataset.py 96.44% <0.00%> (-1.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd91e12...f273aef. Read the comment docs.

clonker commented 2 years ago

Thanks!