search

deeptools / HiCExplorer

HiCExplorer is a powerful and easy to use set of tools to process, normalize and visualize Hi-C data.
https://hicexplorer.readthedocs.org
GNU General Public License v3.0
233 stars 70 forks source link

Build failing in python 3.6 - hicAggregateContacts #197

Closed gtrichard closed 6 years ago

gtrichard commented 6 years ago

Hello,

I checked Travis CI building of the documentation branch and I saw that the build is failing only in python 3.6 at the test_hicAggregateContacts_3d step, you can check the error messages here:

https://travis-ci.org/deeptools/HiCExplorer/jobs/341337111

joachimwolff commented 6 years ago

@gtrichard Should be fixed. @all Please use from __future__ import division instead of the Python 2 standard division. It is difficult for me to figure out where an integer division is wanted (e.g. if the values should be used as indices like it was in this case) or where it should be a floating one. Using the division from __future__ uses the Python 3 method i.e. 5 / 3 = 1.666 and not 5 / 3 = 1 anymore. To use integer division use 5 // 3 = 1. @fidelram Please check in hicAggregateContacs if I am using the divisions as they were meant to be used.

gtrichard commented 6 years ago

@joachimwolff Could you push this modification to the documentation branch to see if the build is successful after these changes?

Otherwise, how should I proceed?

That red cross near each commit is stressing me 😃