deeptools / HiCExplorer

HiCExplorer is a powerful and easy to use set of tools to process, normalize and visualize Hi-C data.
https://hicexplorer.readthedocs.org
GNU General Public License v3.0
233 stars 70 forks source link

hicFindRestSite galaxy wrapper 3.6 complains about restriction enzyme sequence #701

Closed cgirardot closed 3 years ago

cgirardot commented 3 years ago

Hi @joachimwolff I am now upgrading my galaxy WF to use the latest version and encountered this problem in hicFindRestSite. The ER sequence validation seems to have a bug and complaints even though the sequence is valid.

Screen Shot 2021-04-07 at 18 53 18
joachimwolff commented 3 years ago

Hi,

There is a validator which checks if the characters entered are ascii. https://github.com/galaxyproject/tools-iuc/blob/master/tools/hicexplorer/hicFindRestrictionSites.xml#L22

Maybe @bgruening who added this validation can explain how to enter a sequence the correct way. For me your sequence looks alright.

Best,

Joachim

cgirardot commented 3 years ago

Thanks for looking into this. It is most likely JS related. I forgot to mention: I was using Chrome and switching to Firefox did not fix it.

joachimwolff commented 3 years ago

So it seems that we use a function that requires Python 3.7. Is it possible for you to upgrade to Python 3.7?

joachimwolff commented 3 years ago

For 3.6 we work on a fix, because our server runs with Python 3.6 too.

cgirardot commented 3 years ago

you mean the python version that runs galaxy I guess. I need to check with Jelle as we actually planned to update to the newer galaxy tonight.

joachimwolff commented 3 years ago

Yes, the Python version that Galaxy is using.

However, Bjoern has a workaround: <validator type="expression" message="Only ASCII characters are allowed."><![CDATA[all(ord(c) < 128 for c in value)]]></validator>

On our server it works now, I will create a PR at tools IUC with this fix.

joachimwolff commented 3 years ago

https://github.com/galaxyproject/tools-iuc/pull/3583

The fix should be available.

Best,

Joachim

cgirardot commented 3 years ago

thx a lot, we'll check this out