Fix the build with Python 3 and an external curl

deeptools / pyBigWig

A python extension for quick access to bigWig and bigBed files

MIT License

212 stars 48 forks source link

Fix the build with Python 3 and an external curl #76

Closed rmsds closed 5 years ago

rmsds commented 5 years ago

the output of subprocess (foo) is a byte-string, which on Python 2 compares fine with a string "-L", but not on Python 3
changing the right side of the comparison with "-L" doesn't work because the propagated byte-strings then fail on the calls to distutils

dpryan79 commented 5 years ago

I'm a little surprised that I haven't run into this issue, since we use python3 for most things. Thanks for fixing this though! I'll merge it and make a release once TravisCI is done with the testing.