deepweeb / B-B-W

0 stars 1 forks source link

Renamed package and removed B-B-W directory #192

Closed tjappo closed 7 years ago

tjappo commented 7 years ago

158

Introduction

Cleaned the project directory by removing the B-B-W folder and renaming the package.

Purpose

Cleaning the files that are not used and/ or do not follow the guidelines of naming packages.

Details

none

Future Applicability

The new package name is nl.tudelft.bbw.*

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling ffdefabaa9a3352298e5b78dd2bc56156a7ede6f on feature/cleanDirectory into on develop.

tjappo commented 7 years ago

Pulled from the feature/travisTimeoutFix into this branch to increase the chance that the travis build succeeds.

ashay123 commented 7 years ago

Just renaming things, when the build succeeds this can be merged.

deepweeb commented 7 years ago

Don't forget the PR labels

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 576b9c27500bcae43e22a47b27a285707649a7ba on feature/cleanDirectory into on develop.

ghost commented 7 years ago

A lot of merge problems will be avoided when performing this merge later as a lot of classes inside Luat's, Ashay's, and my own PRs are still inside the old b_b_w package giving a lot of missing import errors.

tjappo commented 7 years ago

When you merge this pr, you can easily merge it, by rightclicking on your package and press rename package.

ghost commented 7 years ago

True, but then these refactoring changes will be included in my own branch while it should be done in this branch

tjappo commented 7 years ago

When this pr gets merged, the new classes should be in the bbw package as well. It is just that you have to make sure that your new classes are in the new package, and this is making sure that your branch is able to merge with the new develop branch. So of course this is addressed in your pr as well, but that does not mean the issue cannot be addressed earlier.

ghost commented 7 years ago

The moving of my classes to the new package is not my responsibility and should happen in this pull request.

tjappo commented 7 years ago

However, making sure that your pr is able to merge with the 'new' develop branch is, in case this pr gets merged.