search

deepy / sonar-crowd

GNU Lesser General Public License v3.0
32 stars 37 forks source link

Resolve Issues SONARPLUGINS-2931 (Update pom.xml) and SONARPLUGINS-3028 (Use the sonar.security.realm property) #2

Open jamesd35 opened 10 years ago

jamesd35 commented 10 years ago

This fix is to change CrowdPlugin to use the new CrowdRealm, which extends SecurityRealm, instead of CrowdAuthenticator. As a result, one needs to change the SONARQUBE_HOME/conf/sonar.properties file accordingly:

sonar.authenticator.class: org.sonar.plugins.crowd.CrowdAuthenticator to sonar.security.realm: Crowd

This version is not backwards compatible with the old configuration using sonar.authenticator.class.

jblievremont commented 10 years ago

Hi James, thanks for your pull request!

As stated on the SonarQube Users mailing list, we currently lack the expertise and infrastructure here at SonarSource to evaluate your work before integration and we are actively looking for someone to become maintainer of the plugin (with push rights on the repository and full ownership over the release process).

You can participate to the discussion on https://github.com/SonarCommunity/sonar-crowd/pull/1

aheritier commented 10 years ago

Hi @jamesd1111

Thnaks for your contribution. In fact PR #1 already includes your 2 changes (and many more).

aheritier commented 10 years ago

Fixed by PR #1 Will be in version 2.0

stalxed commented 10 years ago

When this release(2.0) is planned?

aheritier commented 10 years ago

Good reminder @stalxed . I need to update few docs and launch the release process (with the hope to have few feedbacks). Myself I'm using a SNAPSHOT for 2 months and I have no big issue excepted for https://jira.codehaus.org/browse/SONAR-4950 for which there is a workaround and the fix should come soon. Perhaps you could give a try to the SNAPSHOT (http://repository-sonarplugins.forge.cloudbees.com/snapshot/org/codehaus/sonar-plugins/sonar-crowd-plugin/2.0-SNAPSHOT/sonar-crowd-plugin-2.0-SNAPSHOT.jar) and give me few feedbacks ?

stalxed commented 10 years ago

Thank you for plugin! I test this plugin in next envirmoment:

Works fine!:

Questions: 1) Do you plan to update members on the timer(like in Atlassian products)? 2) I not test yet, but question. This pluigin support Crowd Single sign-on? Or will be in future?

aheritier commented 10 years ago

Thanks a lot @stalxed for your feedback. About the background sync I proposed it to the core team https://jira.codehaus.org/browse/SONAR-4950?focusedCommentId=351146&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-351146 (cc @gaudol @bellingard ). I think it should be done in the core and I'm not sure we can do it on the plugin side (at least something clean) About SSO it should be possible (http://jira.codehaus.org/browse/SONARPLUGINS-694) but I didn't yet started to implement it.