search

deepy / sonar-crowd

GNU Lesser General Public License v3.0
32 stars 37 forks source link

JAXB and java 11 (using aop) #29

Closed frdeboffles closed 5 years ago

frdeboffles commented 5 years ago

fixes #25 Added javax.xml.bind:jaxb-api:2.3.0, javax.activation:activation:1.1, com.sun.xml.bind:jaxb-core:2.3.0 and org.glassfish.jaxb:jaxb-runtime:2.3.0 dependencies. Forced the thread ClassLoader to use the class ClassLoader on all public methods in this package. AOP weaving done at compile time by aspectj-maven-plugin.

This is an alternate way of wrapping all the public methods to set the right ClassLoader. The compilation of this plugin will work with Java 11 because it is using com.nickwongdev:aspectj-maven-plugin:1.12.1 (see https://github.com/mojohaus/aspectj-maven-plugin/pull/45). This should be reverted to the official org.codehaus.mojo:aspectj-maven-plugin when the following issue is fixed: https://github.com/mojohaus/aspectj-maven-plugin/issues/41

frdeboffles commented 5 years ago

Tested compilation with jdk 11 using:

docker run -it --rm --name sonar-crowd-maven-project -v "$(pwd)":/opt/frd -w /opt/frd maven:3.6.1-jdk-11 mvn clean install