Updated to sonar plugin api version 5

deepy / sonar-crowd

GNU Lesser General Public License v3.0

32 stars 37 forks source link

Updated to sonar plugin api version 5 #3

Closed martinspielmann closed 6 years ago

martinspielmann commented 9 years ago

sonar-plugin-api was updated to version 5. additionally all depricated methods and classes have been removed or replaced

aheritier commented 9 years ago

Hi @pingunaut

Thx a lot for this contribution. I have 2 remarks :

About the style : Could you update your contribution without changing the code format of files. Several files diffs are unreadable (at least not easily). AFAIR the codebase was reformatted to follow SonarQube conventions : https://github.com/SonarSource/sonar-developer-toolset
About the goal : This update will make the plugin compatible only with SonarQube 5.0+ (AFAIU ?) while the current LTS is 4.5.2. I don't know if it's not too early. If few Sonar core devs (ping @bellingard @fmallet @simonbrandhof) could give us some feedback about such change compared to the product roadmap.

Cheers

martinspielmann commented 9 years ago

@aheritier Thanks al lot for your hints and resources! I updated the code with correct format now and downgraded plugin api version to 4.5.2 LTS. I think you are right, pointing out that 5+ would be too early.

Best regards

aheritier commented 9 years ago

thanks a lot @pingunaut it is readable now. @bellingard @fmallet any recommendation/best practice about the minimal Sonar version to support in plugins ?

bellingard commented 9 years ago

Yep @aheritier => we try to keep compatibility with latest LTS (so 4.5 currently) as much as possible. When it's not possible, then we just use the version that we need.

martinspielmann commented 9 years ago

any news on that one? LTS version 4.5.2 was added. we are using this one since start of year in production with no issues detected so far, so seems to be stable.

deepy commented 6 years ago

Closing this since we're now targeting 6.7 (current LTS)