search

deepy / sonar-crowd

GNU Lesser General Public License v3.0
32 stars 37 forks source link

feature: compatibility with sonarqube 9.0 #43

Closed rpaasche closed 3 years ago

deepy commented 3 years ago

Great work! This looks fine, but I can't test it until tomorrow, based on #42 this sounds like it'd work for 8.9 and with 8.9 being the current LTS that'd be a great target

rpaasche commented 3 years ago

Hmmm strange. 2.1.3 worked just fine on 8.9.43852 for us.

ccmuhub commented 3 years ago

I've just tested this PR on sonarqube-enterprise-9.0.0.45539.zip to Crowd 4.3.0 and can confirm that it is working as expected (9.0.0 with the current 2.3.0 plugin version did not work). Gets my tick of approval! Thanks rpaasche

rpaasche commented 3 years ago

@deepy do mind switching to java 11 since the server dose not support running on java 8 anymore?

https://docs.sonarqube.org/8.9/requirements/requirements/

deepy commented 3 years ago

no complains about 11 from here, I'll test that as well to make sure there's nothing sneaking up on us

deepy commented 3 years ago

I wonder if I can automate the integration testing from my end, starting two servers and doing some REST calls shouldn't be too difficult

deepy commented 3 years ago

Alright I tested this with 8.9 and group syncing works so I think it should be safe to release