search

deerawan / vscode-dash

Dash, Zeal and Velocity documentation integration in Visual Studio Code 🔎📖
MIT License
289 stars 23 forks source link

`dash.docset.` settings do not work #33

Closed nikitavoloboev closed 5 years ago

nikitavoloboev commented 6 years ago

I added this to my settings.js file:

  "dash.docset.typescript": [
    "typescript",
    "javascript"
  ],

Assuming that it will only search these two docsets when you run the Dash hotkey in .ts files but that did nothing. It still searches through all these docsets:

2018-08-02 at 14 45

Is this a bug? Or I did something wrong?

deerawan commented 6 years ago

Hi @nikitavoloboev

I also can reproduce your issue. I threw a question to the Dash developer regarding this. Will keep you posted.

Thank you

deerawan commented 6 years ago

@nikitavoloboev

Got this answer from author of Dash

if you send "typescript" (e.g. for a "ts" file) anything TypeScript-related gets activated.

He also mentioned that there is a workaround for this issue by adding keyword exact. Will investigate this.

I also agree that it is not supposed to open other docset outside the configuration.

nikitavoloboev commented 5 years ago

This still fails for me @deerawan

My settings:

  "dash.languageIdToDocsetMap": {
    "typescript": ["typescript", "javascript"]
  },

I go to .ts file and activate extension.

2019-03-19 at 11 50

Result:

2019-03-19 at 11 50

nikitavoloboev commented 5 years ago

@deerawan Any way to know why this happens? Did I do something wrong?

kassi commented 4 years ago

Doesn't work for me anymore, either. I'm pretty sure it worked before and without specifying any sort of language or file name map. Exact keyword doesn't change anything.

Ok, I sorted this out. Looks like I had to add all languages to the dash.languageIdToDocsetMap but used an array instead of a hash. VSCode didn't complain, but now it's working. Using Dash 4 still btw.