fixes for Velocity on Windows (switching from 'start' technique to 'cmd /c')

deerawan / vscode-dash

Dash, Zeal and Velocity documentation integration in Visual Studio Code 🔎📖

MIT License

289 stars 23 forks source link

fixes for Velocity on Windows (switching from 'start' technique to 'cmd /c') #47

Closed cuylerstuwe closed 5 years ago

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling a66fc05f711208302af7af56f4263dc37da98431 on salembeats:master into 238d7bc4004811d81932106503b561af8e854b6c on deerawan:master.

deerawan commented 5 years ago

@salembeats we still have a conflict file here 😃

cuylerstuwe commented 5 years ago

Yeah, it's been about a month, so that's not a surprise.

Should be good now.

cuylerstuwe commented 5 years ago

Let me double-check a few things and make sure types are right and all of that.

cuylerstuwe commented 5 years ago

There we go, good to go. Class is much more concise.

deerawan commented 5 years ago

looks good