Closed andredevjs closed 1 year ago
Name | Link |
---|---|
Latest commit | 073ae307872f0a66000caa086c72b29b22bf408d |
Latest deploy log | https://app.netlify.com/sites/fabulous-meringue-01474b/deploys/64c19c4c1e0f8b00088b79f0 |
Deploy Preview | https://deploy-preview-276.test.deezy.place |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
collections page does seem to load pretty quickly
the lowercase title doesn't look great, but that's not part of this pr
These show up as listed but when you click on them, there is no buy button. I wonder if you have introduced a regression in the logic that checks if a listing has been invalidated (by being spent)
Still going thru full PR review and code review, but noticed a few things during QA:
- We are not displaying the value of un-inscribed UTXOs in the wallet any longer
- Not a regression, but will make new task. You cannot view or send uninscribed UTXOs any longer either
- Something is causing the marketplace page to load slower now
Collections page definitely loads quicker. Need to test loading a wallet with many inscriptions as well.
It was my suggestion to remove the value of a utxo - it was confusing when the same text was used for price
Also general feedback for the future, lets avoid having multiple linear tasks in a single branch. Leads to them getting backed up.
agreed on this
@andredevjs can you fix merge conflicts please?
Lots of things behind the scene.
What you should see, is that if you load a collection page like https://deploy-preview-276.test.deezy.place/collection/nosfter-holics, it should load right away. Items on auction should load first, then the collection and at some points, the rest of the items from nostr.
There is a lot of changes on the card, please refer to the tasks below, main changes are:
Related tasks are: https://linear.app/deezy/issue/ENG-35/collections-page-should-be-optimized-to-load-auctions-and-on-sale https://linear.app/deezy/issue/ENG-31/default-price-for-items-should-be-in-btc-not-sats https://linear.app/deezy/issue/ENG-104/remove-listed-time-from-ordinal-card https://linear.app/deezy/issue/ENG-103/for-items-of-the-collection-in-sale-display-always-buy-button https://linear.app/deezy/issue/ENG-101/display-btc-value-in-items-for-sale-with-icon https://linear.app/deezy/issue/ENG-100/display-meta-name-in-collection-instead-of-inscription-number https://linear.app/deezy/issue/ENG-99/identify-cards-on-auction https://linear.app/deezy/issue/ENG-98/make-whole-ordinal-card-clickable https://linear.app/deezy/issue/ENG-86/update-auction-endpoint-with-new-aws-account https://linear.app/deezy/issue/ENG-96/redis-for-collections-cache https://linear.app/deezy/issue/ENG-61/create-script-to-pre-load-collection-data https://linear.app/deezy/issue/ENG-58/turbo-api-get-collection-with-inscriptions-data https://linear.app/deezy/issue/ENG-60/create-endpoint-to-get-collection-with-all-inscription-data https://linear.app/deezy/issue/ENG-59/setup-redis