def-gthill
commented
1 year ago For commit e4a13fb (save trace when intermediates are off): Good catch on this, yes it's almost certainly a bug. I pretty much always have intermediates on so I missed this. Good work, no changes needed!
For commit 80c7896 (add syllables to trace): Great work again. I'm pretty sure this fixes #55, and in exactly the way I would have fixed it.
For commit d295f61 (show original word in trace): I can see what you're going for here, but I'm not sure I like it as is. If I'm only tracing one word, I get "Applied some-sound-change to cukucaku" over and over again. It's a bit cluttered for no gain.
If I'm tracing more than one word, I think showing the original word like this is a great idea, to make it clear which changes are being applied to which words. At least once I've used the trace feature to figure out why two similar words were diverging, and showing the original word would've helped a lot with that.
My suggestion:
- Only show the original word when there's more than one word being traced.
- Add a line to the beginning listing the words that are being traced, e.g.
tracing karapuna, teyoomi. This provides the context when I'm only tracing one word, and also makes it clearer what's happening in situations where one of the traced words doesn't change at all.
neta-elad
Thanks, I'll take a look at this on the weekend, along with @AdamantConlanger's bug reports.