search

def-gthill / lexurgy

A high-powered sound change applier
GNU General Public License v3.0
42 stars 5 forks source link

Wrong circular inclusion detection #75

Closed neta-elad closed 9 months ago

neta-elad commented 9 months ago

Currently, if the same file is included twice an error is always thrown. This fixes the inclusion logic such that an error will be thrown only when there is actually a circular inclusion, and also adds tests.

neta-elad commented 9 months ago

@def-gthill - I also noticed that the version in the gradle files is incorrect (1.3.2 instead of 1.3.3), but I don't know if you want me to fix it in this PR or do it separately.

def-gthill commented 9 months ago

@def-gthill - I also noticed that the version in the gradle files is incorrect (1.3.2 instead of 1.3.3), but I don't know if you want me to fix it in this PR or do it separately.

This is because I hadn't pushed the latest changes to master, only the 1.3.3 tag itself.

You probably don't want to pull in the 1.3.3 changes. Apparently the CLI has a hanging thread problem.