search

defano / wyldcard

A clone of Apple's HyperCard and HyperTalk scripting language.
https://github.com/defano/wyldcard/wiki
MIT License
117 stars 12 forks source link

Bug: "the ClickLine" attribute/function should return the " of <short name of target>" #106

Closed ooper-zz closed 2 years ago

ooper-zz commented 2 years ago

Currently, "the clickline" returns only the line number of the field's clicked row, not the full parent, in the form of "line 1 of <card | background> field ".

This bug can be found in the "Audio Help" stack. It can be duplicated by writing a simple mouseUp script on a locked text field: on mouseUp answer the clickLine --should answer "line x of card field x" end mouseUp

ooper-zz commented 2 years ago

I will be working on this fix and send a PR when I am done.

ooper-zz commented 2 years ago

Quick update. I got this functionality working. I will finish the test and the PR Friday (tomorrow for me).

ooper-zz commented 2 years ago

I submitted a Pull Request

defano commented 2 years ago

Thanks, @ooper-zz . I left you a review comment—I think the implementation for the clickLine can be simplified. Take a look and let me know if you disagree.

ooper-zz commented 2 years ago

Sorry, it's probably me learning Github, but I can't find your review comments for the pull request on pull #113. I am looking at the Conversation tab for it and see 0 🧐

Sent from my iPhone

On May 31, 2022, at 7:41 PM, Matt DeFano @.***> wrote:



Thanks, @ooper-zzhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fooper-zz&data=05%7C01%7C%7C0c1a7a5d50af41508f5e08da4378389f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637896480871770154%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TSplip8Jy9%2FnUtukqlIYlbqfvI5lWFw9oWASkjWFSjM%3D&reserved=0 . I left you a review comment—I think the implementation for the clickLine can be simplified. Take a look and let me know if you disagree.

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdefano%2Fwyldcard%2Fissues%2F106%23issuecomment-1143056892&data=05%7C01%7C%7C0c1a7a5d50af41508f5e08da4378389f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637896480871770154%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VTBJE1UfFXSgPfzUG9Sqs%2FzD%2BVwXj9qynqmgsAxJPWE%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAZ473XFS6VSNTJYGSGIUQLVM3EVJANCNFSM5W3XP3UQ&data=05%7C01%7C%7C0c1a7a5d50af41508f5e08da4378389f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637896480871770154%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IRDGYQARdVmL2fkhgjxjstbK3X4uAWX%2FgOMw1n5iVhY%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

ooper-zz commented 2 years ago

Hey @defano, I'm sorry, I can't find the PR review comment and what the simplification should be :( If you could add a link to this thread, It would be great and highly appreciated. Thanks!

At any rate, I am on vacation and will be until the latter part of week of June 13.

defano commented 2 years ago

Hi @ooper-zz , try now—I think I forgot to "submit" the review back to you. Enjoy your vacation!

ooper-zz commented 2 years ago

Thanks @defano, we did!

I submitted the changes you suggested. Best approach, for sure. Take care.

defano commented 2 years ago

Awesome—thanks, @ooper-zz. I have merged your changes.