defaultxr / cl-patterns

Library for writing patterns to generate or process (a)musical sequences of mathematically (un)related (non-)compound values in Lisp.
https://w.struct.ws/cl-patterns
MIT License
77 stars 10 forks source link

None of the examples in the supercollider example work for me #39

Closed cianoc closed 1 year ago

cianoc commented 1 year ago

I can load the library fine, and compile the synths. However when I tried to run a pattern from the version in quicklisp, it would complain that There is no applicable method for the generic function

So I tried the latest version in github instead, and I no longer get an error. However when I run the clock nothing happens. And if I try to call a synth directly as follows: (synth 'default)

I get the error:

There is no applicable method for the generic function
  #<STANDARD-GENERIC-FUNCTION CL-COLLIDER::ID (2)>
when called with arguments
  (NIL).
   [Condition of type SB-PCL::NO-APPLICABLE-METHOD-ERROR]

This is on SBCL on the Mac (M1).

defaultxr commented 1 year ago

Hmm... I think I see the issue. After you run (cl-patterns:backend-start 'supercollider), if you enter cl-collider:*s* into the REPL, does it show NIL?

I'm guessing that is the problem, and it seems to be because the unless on this line should be a when instead. You can edit it yourself but I'll also push a fix for that once I have a moment to double check.

defaultxr commented 1 year ago

I think that was probably the issue. Let me know if you're still having any problems after updating to the latest git master.

cianoc commented 1 year ago

Yes that fixed it for me. Sorry for not getting back sooner.

Thanks for fixing it!

defaultxr commented 1 year ago

No problem, and glad to hear it! And thanks for reporting :)