Closed LKD-PIX closed 10 months ago
This issue occurs with the above drop method. LootContext.Builder must contain valid variables to normalize drops, but other mods sometimes throw in "incomplete" arguments.
The "incomplete" LootContext.Builder is caused by another mod and cannot be addressed by HaC. All HaC can do is return the default drop content of the "incomplete" LootContext.Builder. (This will be fixed in the next update.) Compatibility with mining using hand tools is not guaranteed.
Alright, i will link this issue to every Mod-Author where i come across issues 👍
It was temporarily fixed in eaeee00. A fix for some possible NPEs, not a complete fix. If additional crashes occur, I'll consider other fixes.
It as of testing now seems to have fixed all issues
For your information.
Method signiture of getDrops
public static List<ItemStack> getDrops(BlockState pState, ServerLevel pLevel, BlockPos pPos, @Nullable BlockEntity pBlockEntity, @Nullable Entity pEntity, ItemStack pTool)
Quarry calls this method with entity=null
to get drops from a block when player information is not available. In 1.19.2 with Forge, FakePlayer can be used to fill this parameter so I changed my code to use FakePlayer in all methods collecting drops.
At a3c822d improved the handling of Block#getDrops, so I think this problem has been fixed. The next update will include this commit. thank you!
If any Quarry or Autobreaker from other Mods, break your ORE server crashes.
For Example RFTools Builder, or Electrodynamics Quarry.
I think it's an Issue with FakePlayer getting the Block-Drop