Fix profile.js v2 - Githubissues

defendtheweb / NexBot

Node.js IRC bot

Other

8 stars 8 forks source link

Fix profile.js v2 #52

Closed Pawda closed 10 years ago

Pawda commented 10 years ago

Now only display error in console if debug is set to true.
Remove implicit variable declaration of matches & user.
Replace https.request by https.get for semantic.
Update the way request data is acquired: As per the man, the event 'data' isn't necessarily giving the full body request but a chunk. We only can be certain a request has been completed under the 'end' event. Therefore, we should aggregate chunks and parse the whole data into JSON after that.

Pawda commented 10 years ago

After checking with the website repository, I'm noticing even the url to the api is wrong and the api doesn't even contains the method for displaying profile. Is there an explanation for that ? Is that because it's actually referencing the api of a previous version of hackthis ?

lwward commented 10 years ago

This is indeed an old API that was removed. However a new version of the API will be introduced in the near future so it is still a good idea to maintain this module. The API for this module could be fast tracked and added asap.

lwward commented 10 years ago

The profile module has been replaced by the WeChall API that has been added to HT!! All is now functioning correctly. Thank you anyway for your contribution @Pawda