Include GovCloud in tests - Githubissues

defenseunicorns / delivery-aws-iac

Apache License 2.0

16 stars 5 forks source link

Include GovCloud in tests #297

Closed RothAndrew closed 1 year ago

RothAndrew commented 1 year ago

Closes #239

Changes:

Significantly simplify the main test-command.yml workflow by abstracting the major sections of it into independent GitHub Actions
Fix a bug in the pre-commit action that would incorrectly skip golang caching if check-type was set to all
Update the E2E tests from one job that tests in the commercial account to 2 separate jobs that run in parallel; one for the commercial account and the other for the govcloud account.

Notes:

(Repeated here for visibility) I believe this is good to go, but can't be 100% sure since a bunch of it only works out of the main branch. Recommended approach to reviewing this is to do a review of the code, get it merged, then open a dummy PR to test.

RothAndrew commented 1 year ago

I believe this is good to go, but can't be 100% sure since a bunch of it only works out of the main branch. Recommended approach to reviewing this is to do a review of the code, get it merged, then open a dummy PR to test.