search

defenseunicorns / delivery-aws-iac

Apache License 2.0
16 stars 5 forks source link

fix(ci): Change the parse job in test and update workflows to always use main #332

Closed RothAndrew closed 1 year ago

RothAndrew commented 1 year ago

The Parse job should always be using the action that is in main. This is a bug that got introduced when switching to using a reusable action. Before that change it did always use main, but the change to using a reusable action inadvertently also made it use the action from the PR's branch rather than main. This resulted in this error

RothAndrew commented 1 year ago

/test all :robot: View pipeline run

RothAndrew commented 1 year ago

/test all :robot: View pipeline run

RothAndrew commented 1 year ago

Actually now that I'm looking at this more, I wonder whether we would like the jobs that use reusable actions to use the branch rather than main? That would likely help us get around one of the headaches with this approach. IMO doing so would not be much of a security risk since only maintainers of the repo with write access can trigger the workflows.

@zack-is-cool thoughts?

RothAndrew commented 1 year ago

/test all :robot: View pipeline run