search

defenseunicorns / lula

The Compliance Validator
Apache License 2.0
147 stars 23 forks source link

Error finding file path when composing a component-definition #684

Closed CloudBeard closed 2 weeks ago

CloudBeard commented 4 weeks ago

Environment

Device and OS: Ubuntu 22.04 App version: v0.7.0 Kubernetes distro: N/A Kubernetes version: N/A provider: N/A

When composing a component-definition that imports a component-definition that contains a remote validation of a file path will error due to current file path lookup functionality and not find the validations.

Steps to reproduce

  1. git clone https://github.com/defenseunicorns/uds-core.git
  2. lula tools compose -f compliance/oscal-component.yaml -l debug
  3. Check the log file to see the warning.

Expected result

component-definition.yaml is created that contains the imported component-definition's remote validations are listed in the back matter when compared to composing that component-definition individually.

Actual Result

The imported component-definition's remote validations are not found due to current file path functionality.

Visual Proof (screenshots, videos, text, etc)

image

Severity/Priority

Moderate/Moderate

brandtkeller commented 2 weeks ago

Not able to reproduce the debug messages for v0.8.0 or main of Lula.

CloudBeard commented 2 weeks ago

Also verified in UDS Core branch where bug was first discovered. No issues with main.

Resolved as apart of https://github.com/defenseunicorns/lula/pull/686