chore: improve spinner when used with `--no-progress`

defenseunicorns / maru-runner

The Unicorn Task Runner

Apache License 2.0

8 stars 0 forks source link

chore: improve spinner when used with `--no-progress` #105

Closed Racer159 closed 1 month ago

Racer159 commented 1 month ago

Description

This slightly improves the spinner to allow for interactive programs to run when --no-progress is provided.

Related Issue

Relates to #103

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Other (security config, docs update, etc)

Checklist before merging

[X] Test, docs, adr added or updated as needed
[X] Contributor Guide Steps followed

marshall007 commented 1 month ago

Are there relevant tests I can run to reproduce the issue? Spinner has never printed cleanly for me, at least in the context of uds-cli so happy to try this out.

marshall007 commented 1 month ago

via Slack:

The easiest way to test it is to run maru inside maru (basically build it and then call build/maru in a task) then run the parent command with and without --no-progress

This worked for me (I think) but should we add this to the e2e tests to clarify expected behavior?