feat: refactor action into a interface

defenseunicorns / maru-runner

The Unicorn Task Runner

Apache License 2.0

8 stars 0 forks source link

feat: refactor action into a interface #29

Closed naveensrinivasan closed 3 months ago

naveensrinivasan commented 3 months ago

Description

refactor the actionrunner and actioncfg into an interface to help create unit tests.

Related Issue

Fixes #

Relates to #

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[ ] Test, docs, adr added or updated as needed
[ ] Contributor Guide Steps followed

naveensrinivasan commented 3 months ago

I think the abstraction created by the interface doesn't quite make sense. I think we'll only ever have Zarf action runners implement this interface. Understood this makes mocking in unit tests a bit easier but I don't that's worth the extra abstraction.

Closing this 👍