defenseunicorns / pepr

Type safe K8s middleware for humans
https://pepr.dev
Apache License 2.0
209 stars 17 forks source link

Unpublish or Deprecate `pepr:0.0.0-development` from NPM registry #1120

Closed samayer12 closed 2 months ago

samayer12 commented 2 months ago

Environment

Device and OS: MacOS App version: Local Development Kubernetes distro being used: k3d Other: N/A

Steps to reproduce

npm run test:journey:build
npx --yes file:pepr-0.0.0-development.tgz init --skip-post-init
# Name module `pepr-test-module`
cd pepr-test-module 
npx --yes file:../pepr-0.0.0-development.tgz build

Expected result

I can successfully run npx ${PEPR_ALIAS} build without errors as shown below.

Actual Result

Module does not build.

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

Medium

Additional Context

0.0.0-development was accidentally published to the npm registry. As a result, one issue I ran into was working on a local development version of Pepr, which would build a new local artifact. However, running any pepr commands (e.g., npx file:pepr-0.0.0-development.tgz build) would actually pull from npm and fail with an error. Since this is an opaque failure conditiona, this has added significant troubleshooting time to development.

NPM unpublishing docs.

btlghrants commented 2 months ago

Just gave the un-pub a try -- since my NPM creds were working -- and it looks like NPMjs wants us to deprecate it instead (because it has dependents). :cry: image

IRT our troubleshooting collab today, I think a deprecation would've been enough to let us know something was wrong (cuz the npm install would have complained about us using a dep'd version).

...but now, as I go back to try & deprecate it, my NPM creds have dropped again. sigh

Next person in line (or future me if my creds come back): try to deprecate it!

btlghrants commented 2 months ago

Working with tech support to get my the NPM creds sorted right 'chnow. :crossed_fingers:

btlghrants commented 2 months ago

Alllllll righty -- was able to get the account creds all sorted. NPMjs.com's pepr@0.0.0-development officially deprecated.

image

cmwylie19 commented 2 months ago

got it, looks good to close.